Adding kb0287.json and kb0287.sh #11
Conversation
tasks/kb0287.sh
Outdated
| @@ -0,0 +1,18 @@ | |||
| #!/bin/bash | |||
| # Puppet Task Name: KB0287 | |||
| # shellcheck disable=SC2078 | |||
There was a problem hiding this comment.
Any reason for disabling the shellcheck rather than changing the if statement to comply?
if puppet resource service pe-postgresql | grep -q running
then
echo "pe-postgresql service detected, will continue to run."
There was a problem hiding this comment.
Changed to reflect this.
tasks/kb0287.sh
Outdated
| then | ||
| echo "pe-postgresql service detected, will continue to run." | ||
|
|
||
| su - pe-postgres -s /bin/bash -c "/opt/puppetlabs/server/bin/psql -d $dbname -c '\di+;'" |
There was a problem hiding this comment.
Looks like there is some missing indentation here.
There was a problem hiding this comment.
Bash noob, should be fixed now.
tasks/kb0287.sh
Outdated
| @@ -0,0 +1,18 @@ | |||
| #!/bin/bash | |||
| # Puppet Task Name: KB0287 | |||
There was a problem hiding this comment.
Based on @MartyEwings's email this morning, we should rename this task to include a brief description.
|
@jarretlavallee I have made the suggested changes. I totally agree, it would be nice to have an option to select all tables, so I will add that in a separate PR as I will have to change the KB as well. |
|
Got time today to add the ability to select all tables from all dbs. |
| "parameters": { | ||
| "dbname": { | ||
| "description": "The name of the db to connect to", | ||
| "type": "Enum['pe-puppetdb', 'pe-postgres', 'pe-classifier', 'pe-rbac', 'pe-activity', 'pe-orchestrator', 'postgres', all]" |
There was a problem hiding this comment.
Does the all need to be in single quotes like the other elements in the array?
|
👍 Looks good to me. It is good to merge as long as the enum |
Adding task which will display the selected database's table sizes.