Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-2539) Update terminology and refactor #121

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Aug 16, 2021

This commit replaces references to "master" with "primary" and refactors
the script to regenerate the primary cert.

This commit replaces references to "master" with "primary" and refactors
the script to regenerate the primary cert.
@m0dular m0dular requested a review from a team as a code owner August 16, 2021 17:30
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me so long as its tested

@MartyEwings
Copy link
Collaborator

@m0dular looks like as have a failing shell check,

@m0dular
Copy link
Contributor Author

m0dular commented Aug 17, 2021

Ah that's from st1096, but I can fix it in this PR 👍

@m0dular
Copy link
Contributor Author

m0dular commented Aug 18, 2021

Gave it a quick test on 2021 and 2019 👍

@MartyEwings MartyEwings merged commit f100c65 into puppetlabs:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants