Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Sup-2837) st0236_set_cache_paths_to_default Audit and Update #125

Merged
merged 2 commits into from
Dec 10, 2021
Merged

(Sup-2837) st0236_set_cache_paths_to_default Audit and Update #125

merged 2 commits into from
Dec 10, 2021

Conversation

MartyEwings
Copy link
Collaborator

This commit adds in the use of bash task helper
updates how the task exits on non conforming nodes
allows tests to succeed on PE node

@MartyEwings MartyEwings added the enhancement New feature or request label Dec 10, 2021
@MartyEwings MartyEwings requested a review from a team as a code owner December 10, 2021 12:07
m0dular
m0dular approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in terms of using the helper. I will resist my urge to use all Bash features over /bin/sh and approve it.

@MartyEwings MartyEwings merged commit c95d6ca into puppetlabs:main Dec 10, 2021
@MartyEwings MartyEwings deleted the rework branch December 10, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0dular m0dular m0dular approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartyEwings @m0dular