(SUP-2848) st0361a_uploading_facts convert to ruby #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyEwings
force-pushed
the
SUP-2848
branch
from
0d006f4
to
5b9f5e4
Compare
|
@m0dular are you able to approve? ideally we wouldn't "Shell out" but given this is run infrequently, and the general improvements we have since moving from BASH and powershell this is a positive step |
MartyEwings
force-pushed
the
SUP-2848
branch
from
5b9f5e4
to
c36daf1
Compare
MartyEwings
force-pushed
the
SUP-2848
branch
2 times, most recently
from
d46fece
to
6889ae8
Compare
MartyEwings
force-pushed
the
SUP-2848
branch
from
6889ae8
to
717e80f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes bash and power shell versions
adds spec tests