Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP-3551 Change password to sensitive #150

Merged
merged 2 commits into from
Sep 27, 2022
Merged

SUP-3551 Change password to sensitive #150

merged 2 commits into from
Sep 27, 2022

Conversation

elainemccloskey
Copy link
Contributor

@elainemccloskey elainemccloskey commented Sep 26, 2022 •
edited
Loading

Changed the password parameter in the generate token task to sensitive so it is obfuscated in the console task details.
Also increased bash_task_helper version requirements in metadata due to testing on v2 of the module.

@elainemccloskey elainemccloskey requested a review from a team as a code owner September 26, 2022 16:00
m0dular
m0dular suggested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually know that tasks could declare params to be sensitive, so I thought we'd have to rewrite this to be a task. Nice catch.

We just need a description to be added in the PR and then this is good to go.

@elainemccloskey elainemccloskey merged commit c2d6fbd into puppetlabs:main Sep 27, 2022
@MartyEwings MartyEwings added the enhancement New feature or request label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0dular m0dular m0dular requested changes

@MartyEwings MartyEwings MartyEwings approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elainemccloskey @m0dular @MartyEwings