Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sup-4597 - Deprecation of support_script_and_upload task [st0305] #175

Conversation

Aaronoftheages
Copy link
Contributor

@Aaronoftheages Aaronoftheages commented Nov 3, 2023

The deprecation of task 305 with deprecation message added during runtime.

@Aaronoftheages Aaronoftheages added the enhancement New feature or request label Nov 3, 2023
@Aaronoftheages Aaronoftheages requested a review from a team as a code owner November 3, 2023 16:11
@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch from 8b6470e to 17b2cc2 Compare November 6, 2023 17:56
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

52c0c9c is another merge of main into your feature branch. When a feature needs updating after main receives new commits, it should always be via git pull --rebase. Does this config setting not work for VS code or something?

git config --global pull.rebase true

You should be able to fix this branch with the command below again, but please ensure that updating feature branches is done with pull --rebase in the future.

git pull --rebase origin main -X theirs

tasks/st0305_support_script_and_upload.rb Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch 2 times, most recently from 1dea0b2 to 3b36ba9 Compare November 6, 2023 20:30
@MartyEwings
Copy link
Collaborator

can you rebase using the command @m0dular mentioned

@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch 2 times, most recently from 6fa2572 to 398ed40 Compare November 7, 2023 12:20
@Aaronoftheages
Copy link
Contributor Author

can you rebase using the command @m0dular mentioned

It worked

@m0dular as for the configuration of git and VScode I'm not entirely sure it is sticking so I'll investigate that, or from now on use iterm directly

README.md Outdated Show resolved Hide resolved
tasks/st0305_support_script_and_upload.rb Outdated Show resolved Hide resolved
@Aaronoftheages
Copy link
Contributor Author

Seeing validation errors, running pdk validate -a

@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch 2 times, most recently from 7a1722c to 5d28605 Compare November 7, 2023 14:23
@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch from 6ca59dd to 9338e6b Compare November 7, 2023 15:35
@Aaronoftheages Aaronoftheages force-pushed the SUP-4597_Deprecate_ST0305_support_script_and_upload branch from 78298f5 to 59d0ae9 Compare November 7, 2023 15:59
@m0dular
Copy link
Contributor

m0dular commented Nov 7, 2023

I think @MartyEwings also needs to approve to satisfy the branch protection rules?

@Aaronoftheages Aaronoftheages merged commit 28eb88f into puppetlabs:main Nov 8, 2023
31 checks passed
@Aaronoftheages Aaronoftheages deleted the SUP-4597_Deprecate_ST0305_support_script_and_upload branch November 8, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants