Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-4593 - Deprecation of find_disabled_agents [st0285] #179

Conversation

Aaronoftheages
Copy link
Contributor

Echo and Write-output in respective files with README Update

@Aaronoftheages Aaronoftheages added the enhancement New feature or request label Nov 8, 2023
@Aaronoftheages Aaronoftheages requested a review from a team as a code owner November 8, 2023 13:52
@Aaronoftheages Aaronoftheages force-pushed the SUP-4593_Deprecate_st0285_find_disabled_agents branch from 9304a3d to 4c787cb Compare November 8, 2023 14:28
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the acceptance tests are failing for this one, as it expects a certain output that has now changed.
Options:
update the test
remove the test

advantages and disadvantages of each, updating the test is more effort, but it may be a while before we remove the test, so we may also want to keep the test running

@Aaronoftheages
Copy link
Contributor Author

the acceptance tests are failing for this one, as it expects a certain output that has now changed. Options: update the test remove the test

advantages and disadvantages of each, updating the test is more effort, but it may be a while before we remove the test, so we may also want to keep the test running

If these tasks are getting deprecated then I don't see a point in keeping the tests or updating them, so removing them is probably the most efficient thing to do

@MartyEwings MartyEwings merged commit bef96b2 into puppetlabs:main Nov 8, 2023
30 of 31 checks passed
@Aaronoftheages Aaronoftheages deleted the SUP-4593_Deprecate_st0285_find_disabled_agents branch November 8, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants