Adding SSL dir backup to task kb0263 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarretlavallee
suggested changes
Aug 15, 2018
abottchen
force-pushed
the
add-ssl-backup-kb0263
branch
from
ca70183
to
cc134c6
Compare
|
Yea, it runs as root, so the perms should be covered. Totally overlooked the quotes, though. That's what I get for building this on a test system without shellcheck rather than my workstation... |
|
@jarretlavallee Forgot to tag you on that last update. Shellcheck runs clean now. |
jarretlavallee
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual instructions for this KB tell you to back up the SSL dir. Might as well have the task do it.