Add master certificate regeneration task #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarretlavallee
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
👍 It looks good to me. The travis jobs are failing due to #28, so they should not affect this PR.
|
I am not sure on the naming, so I will leave that to @MartyEwings. Otherwise, this looks great! |
|
the outcome of the out of band discussion is that we do need a mechanism for extra to KB tasks, but this one we will integrate with the KB for now, as it kinda lines up with an article |
abottchen
force-pushed
the
add-master-cert-regen
branch
from
9e467b9
to
06f4ef6
Compare
abottchen
force-pushed
the
add-master-cert-regen
branch
from
06f4ef6
to
bc86403
Compare
|
@jarretlavallee @MartyEwings Ok, I updated the task to refer to KB#0299. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no KB article associated with this task, so I named it "other_".
This task will regenerate a master's certificate. Due to service restarts, it will return an error
when run under
puppet task, but will work anyway. If run using bolt's ssh transport, thiserror can be avoided.
This task will check to if all dnsaltnames present in the existing certificate are
included in pe.conf to ensure they are rolled into the new one. This is a boolean to
override this behavior.