(maint) Upgrade PDK to 1.7.0 and Fix shellcheck issues with new tasks #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MartyEwings can we enable the feature where CI tests have to pass prior to merging? |
|
@jarretlavallee Do we need to upgrade our version of shellcheck? https://github.com/koalaman/shellcheck/wiki/SC1117 states that SC1117 has been retired and should not be emitted. |
added 2 commits
August 22, 2018 11:00
This commit updates to PDK 1.7.0 and disables SC1117 during travis runs.
Prior to this commit, the lint checks failed due to shellcheck lint issue. This commit remeidates the lint issue on the task.
|
@abottchen We rely on the built-in shellcheck in the travis docker images. I believe it is v0.5, so it will eventually be upgraded. We could update it as a part of the build, but it seems like it would add unnecessary time to the runtime and load to travis. I modified this PR to disable SC1117 during travis runs. |
jarretlavallee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, CI jobs were failing due to errors in some new tasks. This commit ignores some checks and fixes some minor lint issues in the new tasks. It also updates to pdk 1.7.0.