(SUP-602) Update task for changing log level #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abottchen
commented
Sep 4, 2018
abottchen
commented
- Added trace as a valid log level
- shortened the parameter from peservice to service
- added the dash back to the service names to make them match up with the actual service names at the OS level
- Removed boilerplate comments
- Removed the check for the target being a Puppet master, since this can be run against any mode type.
- Fixed shellcheck errors
|
Should we add WARN and ERROR as additional log levels to the enum? Some customers may want to limit the logging to higher levels after finishing debugging. |
|
@jarretlavallee I don't see any reason why not. I'll add them in. I'd rather customers run at info level, but I don't see why the task should be opinionated on this. |
- Added trace as a valid log level - shortened the parameter from peservice to service - added the dash back to the service names to make them match up with the actual service names at the OS level - Removed boilerplate comments - Removed the check for the target being a Puppet master, since this can be run against any mode type. - Fixed shellcheck errors
abottchen
force-pushed
the
fix-kb0009-metadata-and-service-names
branch
from
a089efd
to
6e0a09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.