(bug) Replace servername if in user_data.conf [SUP-1217]

[MartyEwings]

[SUP-1217] requires us to sed the old hostname out of user_data.conf before continuing in some circumstances

[MartyEwings]

There is an issue with travis and certain docker containers which keep failing, however the tests are all completing in vmpooler just fine (a part from windows nodes... but the acceptance tests are not windows orientated... ):

┌ [✖] Running against 24 targets.
├── [✔] accn61b3w0o0mho.delivery.puppetlabs.net, redhat-5-x86_64
├── [✔] qqd3ihvki4hxxip.delivery.puppetlabs.net, redhat-6-x86_64
├── [✔] msni544f3gviocn.delivery.puppetlabs.net, redhat-7-x86_64
├── [✔] ui4uwp6j105ta3j.delivery.puppetlabs.net, centos-5-x86_64
├── [✔] irt9ptdc7g906mx.delivery.puppetlabs.net, centos-6-x86_64
├── [✔] ifylrgih0pv6sck.delivery.puppetlabs.net, centos-7-x86_64
├── [✔] a9zrw597ebrvg3u.delivery.puppetlabs.net, oracle-5-x86_64
├── [✔] bcss5gyp9to47fi.delivery.puppetlabs.net, oracle-6-x86_64
├── [✔] alico52lm0ggbeq.delivery.puppetlabs.net, oracle-7-x86_64
├── [✔] smkrp3untl2r3rt.delivery.puppetlabs.net, scientific-5-x86_64
├── [✔] k0qzm3t0pilfbdo.delivery.puppetlabs.net, scientific-6-x86_64
├── [✔] ciuww2eg17wdxxj.delivery.puppetlabs.net, scientific-7-x86_64
├── [✔] ht351rss8bseniy.delivery.puppetlabs.net, debian-8-x86_64
├── [✔] xph5uazlj817jho.delivery.puppetlabs.net, debian-9-x86_64
├── [✔] rtt1r57e5k7vbyl.delivery.puppetlabs.net, sles-11-x86_64
├── [✔] hdxthdzh5bchjpx.delivery.puppetlabs.net, sles-12-x86_64
├── [✔] na12p6xvosx25lr.delivery.puppetlabs.net, sles-15-x86_64
├── [✔] gfap9dekubdxhmv.delivery.puppetlabs.net, ubuntu-1404-x86_64
├── [✔] m2hb95tw99m0zyd.delivery.puppetlabs.net, ubuntu-1604-x86_64
├── [✔] u3kwte0mdge0t5d.delivery.puppetlabs.net, ubuntu-1804-x86_64
├── [✖] c1ax6bzoz5z565r.delivery.puppetlabs.net, win-2008r2-x86_64
├── [✖] f55ut5ygz9aune0.delivery.puppetlabs.net, win-2012r2-x86_64
├── [✖] mrhqtqu0mzsy1ib.delivery.puppetlabs.net, win-2016-x86_64
└── [✖] qh46ndtozfzaxy0.delivery.puppetlabs.net, win-10-pro-x86_64

[abottchen]

I can't speak to the travis or pdk portions of this PR, but the sed command looks good to me.

[tkishel]

Sorry for the delay, ditto