Acceptance for kb0286 (SUP-1355)

[MartyEwings]

PDX 1.13 update too

[MartyEwings]

Darn rubocop that's valid litmus syntax !

[MartyEwings]

@tphoney is the "Params ="not proper litmus syntax? Rubocop is flagging it, do I need to create an exception?

[tphoney]

weeeeeee, ruby at its best
params = { 'puppet_mode' => 'disable', 'reason' => 'taskdisabled' }
so this is assigning the hash to a new variable called params. Generally you dont assign things inside a function call so you have 2 choices.
result = run_bolt_task('support_tasks::kb0286_change_puppet_daemon_runmode', { 'puppet_mode' => 'disable', 'reason' => 'taskdisabled' })
or
result = run_bolt_task('support_tasks::kb0286_change_puppet_daemon_runmode', params: { 'puppet_mode' => 'disable', 'reason' => 'taskdisabled' })

ala https://thoughtbot.com/blog/ruby-2-keyword-arguments

[tphoney]

see my comment, pick one of the two options

[pgrant87]

looks good