Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-624) Execute the PE Support Script and upload it via SFTP #57

Merged
merged 1 commit into from
Oct 8, 2019
Merged

(SUP-624) Execute the PE Support Script and upload it via SFTP #57

merged 1 commit into from
Oct 8, 2019

Conversation

tkishel
Copy link
Contributor

@tkishel tkishel commented Oct 8, 2019

KB#0305

MartyEwings
MartyEwings requested changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@MartyEwings MartyEwings left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Rubocop as a couple of style complaints, first one is just spacing, pdk validate -a will fix that, the other thing is a case statement it wants reworded

@MartyEwings MartyEwings merged commit 3ac618b into puppetlabs:master Oct 8, 2019
@MartyEwings MartyEwings added the enhancement New feature or request label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkishel @MartyEwings