Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ca_extend plans and tasks from this module. #58

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Oct 10, 2019

They now live in puppetlabs-ca_extend on the Forge.

This reverts commit 3d7904f, reversing
changes made to 9eaa0f9.

They now live in puppetlabs-ca_extend on the Forge.

This reverts commit 3d7904f, reversing
changes made to 9eaa0f9.
@jarretlavallee
Copy link
Contributor

Looks good, pending CI. There is still a reference to the KB in the readme that needs to be removed.

@m0dular
Copy link
Contributor Author

m0dular commented Oct 10, 2019

@jarretlavallee Bah, good catch. The KB actually still lives and just got updated, so how should we handle that? The README still links to the correct article

@jarretlavallee
Copy link
Contributor

I would say to remove it since it is no longer implemented here and the KB will be updated to point to the module.

The failure in CI looks to be a resource issue. I am restarting it.

Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the change log, to include tasks added removed since last release?

@jarretlavallee
Copy link
Contributor

We should also consider the semver for the version. Might be able to sneak it into a minor release.

@MartyEwings
Copy link
Collaborator

@m0dular it looks like we have this version released already in the forge, but we need the change log updated to match the changes, and the other new tasks since the previous releases. can you do this in this PR? if not ill merge this in a update separately

@MartyEwings MartyEwings merged commit dc19a03 into puppetlabs:master Nov 26, 2019
@MartyEwings MartyEwings added the enhancement New feature or request label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants