Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows find disabled agents ps1 #66

Conversation

cwebster61083
Copy link
Contributor

No description provided.

Chris Webster and others added 3 commits December 10, 2019 15:44
Added kb0285_find_disabled_agents.ps1 to enable detection of disabled
agents on Windows.

Modified kb0285_find_disabled_agents.json so it will use the correct
version of the script on Linux and Windows.
Updated it so that it functions like the Linux version.
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cross platform targeting is not available pre 2019.x, we may need to leave an additional metadata file for both bash and power shell to maintain backwards compatibility

@cwebster61083
Copy link
Contributor Author

Marty,

Very good point. I will get a metadata file added for Powershell tomorrow most likely and update the PR.

@cwebster61083
Copy link
Contributor Author

@MartyEwings would you recommend that I follow the bellow pattern.
kb0285_find_disabled_agents.json
kb0285a_bash_find_disabled_agents.json
kb0285b_powershell_find_disabled_agents.json

@MartyEwings
Copy link
Collaborator

Dealer's choice, works for me!

Chris Webster added 2 commits December 18, 2019 13:57
Updated kb0285 for backwards compatability.
…bster61083/support-tasks into add_windows_find_disabled_agents_ps1
@cwebster61083
Copy link
Contributor Author

@MartyEwings I have pushed the changes you requested. Let me know if it needs any additional changes.

Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MartyEwings MartyEwings merged commit 44957de into puppetlabs:master Dec 18, 2019
@MartyEwings MartyEwings added the enhancement New feature or request label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants