Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-1533) #77

Merged
merged 4 commits into from
Jan 29, 2020
Merged

(SUP-1533) #77

merged 4 commits into from
Jan 29, 2020

Conversation

pgrant87
Copy link
Contributor

OSP compatibility changes for his db table task

OSP compatibility changes for his db table task
syntax issues dealt with
more syntax changes, this time on arrays
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tasks/st0287_check_db_table_sizes.sh line 17:
echo "${service} service detected, will continue to run against "${dblist[@]}"."
^----------^ SC2068: Double quote array expansions to avoid re-splitting elements.
^----------^ SC2145: Argument mixes string and array. Use * or separate argument.
^----------^ SC2027: The surrounding quotes actually unquote this. Remove or escape them.
In tasks/st0287_check_db_table_sizes.sh line 18:
for db in ${dblist[@]};
^----------^ SC2068: Double quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...
The command "bundle exec rake $CHECK" exited with 1.
cache.2
store build cache

more syntax issues
@MartyEwings MartyEwings merged commit fbaca52 into master Jan 29, 2020
@MartyEwings MartyEwings added the bug Something isn't working label May 6, 2021
@MartyEwings MartyEwings deleted the pgrant87-patch-6 branch July 6, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants