Solarized colors for Term mode and Eshell #7

Merged
merged 2 commits into from Aug 17, 2012

Conversation

Projects
None yet
2 participants
Contributor

osener commented Aug 13, 2012

Eshell bits are from Greg Pfeil's version

I'm not sure if Term mode (and ansi-term, multi-term etc.) is supposed to use ansi-color but I needed these additions.

purcell added a commit that referenced this pull request Aug 17, 2012

Merge pull request #7 from osener/master
Solarized colors for Term mode and Eshell

@purcell purcell merged commit 77f9550 into purcell:master Aug 17, 2012

Owner

purcell commented Aug 17, 2012

Thanks. Sorry for the delay; I've merged these changes, but I half wonder whether "black" should be displayed as white when the theme has a dark background... :-)

Contributor

osener commented Aug 17, 2012

@purcell: No problem, thanks for merging them in. I thought about that and decided to go this way since term-color-* correspond to ansi colors (not foreground, background etc.) and official colors for iTerm2 doesn't make this distinction. I haven't encountered a problem yet but please change it if you think it is wrong.

Owner

purcell commented Aug 18, 2012

No, that's fine -- you've obviously thought about it more than me, so let's wait and see if anyone reports an issue. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment