Submit changes back to Chris Kempson's repo #1

Open
purcell opened this Issue Mar 2, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Owner

purcell commented Mar 2, 2012

@chriskempson's repo has an Emacs version of the themes, but they require color-theme.el:

https://github.com/chriskempson/Tomorrow-Theme/blob/master/GNU%20Emacs/color-theme-tomorrow.el

I should fork his repo and submit my enhanced theme back to him as a pull request. Alternatively, he could direct Emacs users to my version of the theme.

-Steve

mamciek commented Mar 2, 2012

It would be nice if you just send him pull request with just Emacs24 specific enhancements, so users would have real choice between your vision and his :)

Owner

purcell commented Mar 3, 2012

It doesn't work like that -- I have a way of using the same code for both the old and new theming systems, so it would be a lot of extra work to separate the two. Greg Pfeil's solarized theme works a similar way, as you will probably have noticed.

-Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment