New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default group will fail sometime #16

Closed
mut0u opened this Issue Apr 12, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@mut0u
Copy link

mut0u commented Apr 12, 2016

I find that under some condition , the Default group will disappear , so the *Message* buffer and some other buffer will grouped in vc-group.

It is like this :

[ Git:~/workspace/rui/rpc-node/ ]
 *%  *Messages*               820 Messages         
  %  *Help*                   478 Help             
[ Git:~/workspace/rui/service/ ]
   = all4payment.clj        18.7k Clojure          ~/workspace/rui/service/src/rui/core/interaction/all4payment.clj
   = protocol.clj            1.3k Clojure          ~/workspace/rui/service/src/rui/core/payment/protocol.clj

     4 buffers                                     2 files, no processes

I have no idea how to fix it.

@purcell

This comment has been minimized.

Copy link
Owner

purcell commented Apr 12, 2016

I think sometimes the vc code gets confused -- occasionally when operating in buffers I get "this file is not under version control" error messages, when I know that that is not the case. (I haven't found either a pattern to this behaviour, or a fix for it.) This would affect ibuffer-vc in the way you've illustrated. So I don't think there's an ibuffer-vc issue here, really, and will go ahead and close this report.

@purcell purcell closed this Apr 12, 2016

@robario

This comment has been minimized.

Copy link

robario commented Apr 22, 2016

I hope this helps @mut0u .

(advice-add 'ibuffer-vc-generate-filter-groups-by-vc-root
              :filter-return
              #'(lambda (ibuffer-filter-groups)
                  (append '(("*" (name . "^\\*"))) ibuffer-filter-groups)))
@mut0u

This comment has been minimized.

Copy link

mut0u commented Oct 10, 2016

Thanks~

@purcell

This comment has been minimized.

Copy link
Owner

purcell commented Oct 14, 2016

@mut0u Aha, from the fix, I can now better understand what you mean. This probably happens when you kill buffers like *Messages* and they are then re-created with a different default-directory. So ibuffer-vc is working correctly here, but if you always want messages (and magit, compilation) buffers etc. to be grouped separately, @robario's fix is the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment