Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "save as" starting point from "untitled" to last saved name. #746

Open
jaffasplaffa opened this issue Sep 18, 2019 · 6 comments

Comments

@jaffasplaffa
Copy link

commented Sep 18, 2019

As discussed on the pd developers mailing list:

When you do a "save as", instead of starting from the name, "Untitled", Pd should start from last saved name, for example "CombFilter1" and then you can go on and change the name from there.

See this clip:
https://www.youtube.com/watch?v=lv3a83yzmJc

@danomatika

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

What OS and Pd version are you using? I can confirm this happens on macOS 10.14 and Pd 0.50.

@danomatika danomatika added the bug/fix label Sep 18, 2019
umlaeute added a commit that referenced this issue Sep 19, 2019
Closes: #746
@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

while pdtk_canvas_saveas received the filename, but did'nt use it.

it seems that this is intentional: b6b19c7

@danomatika

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

I did a quick test on my system (macOS 10.14) by adding a post to pdtk_canvas_saveas:

::pdwindow::post "$initialfile"

The expected filename is printed and I don't see anything weird happening with saveas for both new and existing files.

EDIT: Filenames with spaces also work as expected.

@danomatika danomatika added this to the 0.51 milestone Sep 19, 2019
@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

to clarify:
Pd-core sends the filename to Pd-GUI's pdtk_canvas_saveas just fine.
It's only that the pdtk_canvas_saveas doesn't use it when calling tk_getSaveFile (or anything else).

This is because "Tk 8.5 on Macintosh" has hickups when the -initialfile flag is used (as per b6b19c7).

I don't know which Tk-version is used for which Macintosh packages.
(I'm pretty sure that the PowerPC package still has such an old version.)

@danomatika

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Pd-core sends the filename to Pd-GUI's pdtk_canvas_saveas just fine.

Yes.

This is because "Tk 8.5 on Macintosh" has hickups when the -initialfile flag is used

Apparently. The commit in question basically applies the same bug to all other platforms.

I don't know which Tk-version is used for which Macintosh packages.

8.5.19 as embedded frameworks in the .app bundle (uses Cocoa)

(I'm pretty sure that the PowerPC package still has such an old version.)

8.4 system frameworks which probably work ok (uses Carbon)

FOLLOWUP: Overall, Tk's transition to Cocoa still has issues.

@danomatika

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Here is a 32 bit Pd build with the savers fix and an embedded Tk 8.6.7: http://docs.danomatika.com/pdbuilds/0.51/Pd-0.50-0-saveas-fix-tk867.zip

It seems 8.6 has fixed the underlying issue as the save panel filename is set as expected. Yet another reason to move forward on macOS...

EDIT: This is most likely a simple fix that could be backported by a patch but that's really only a last resort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.