Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple "save as" windows allowed #751

Open
jmmmp opened this issue Sep 22, 2019 · 12 comments · May be fixed by #764

Comments

@jmmmp
Copy link

commented Sep 22, 2019

Try the following (tested on windows)

  • open/create a patch window
  • press save as
  • use alt-tab to focus on any other program
  • go back to the patch window
  • press save as
  • now you have 2 open save as windows
  • keep doing it, until you have as many "save as" windows as you might find necessary...
@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

do you want to provide a PR to document this?

@jmmmp

This comment has been minimized.

Copy link
Author

commented Sep 22, 2019

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

PR = pull request

do you want to provide a PR to document this?

@umlaeute why document and not fix?

IMO, the open/save dialogs should simply be modal, like in any other application...

BTW, a similar problem occurs with [openpanel] and [savepanel], but they probably should stay non-modal. Instead we can fix it in the core (don't create the dialog if the object already has one).

@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

why document and not fix?

because @jmmmp described a behaviour, which he (most likely) finds odd.

there's nothing inherently and/or obviously wrong with how the "Save As..." currently behaves. I don't know whether the OP meant this as a feature request, a bug report or as a documentation of the current behaviour.

as for @Spacechild1's proposed solution: i find modal dialogs rather cumbersome in multi-window applications like Pd: it's just too easy to hide the modal behind one of the many open windows, which leaves you with a non-responsive Pd (that you can't even quit). this is think is much more problematic than having 23 open "Save As..." windows for a single patch.

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

there's nothing inherently and/or obviously wrong with how the "Save As..." currently behaves.

@umlaeute I'm pretty sure that being able to create more than 1 open/save dialog for the same document is a bug.

i find modal dialogs rather cumbersome in multi-window applications like Pd: it's just too easy to hide the modal behind one of the many open windows, which leaves you with a non-responsive Pd

First, a modal dialog should always stay in front of the parent. The problem you're describing (dialogs hidden by other windows) really applies to the current implementation and modal dialogs would actually solve that! Also, the dialogs should probably be window-modal (and not application-modal), so it wouldn't block the user from interacting with the rest of app.

@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

there's nothing inherently and/or obviously wrong with how the "Save As..." currently behaves.

@umlaeute I'm pretty sure that being able to create more than 1 open/save dialog for the same document is a bug.

why? what is the problem you are experiencing?
(and no, I don't see any need to be able to open multiple "Save As..." dialogs; i just don't see the actual problem)

First, a modal dialog should always stay in front of the parent.

sure.
but what I described was not a theoretical problem but a real world problem: I know that I have had modal file-selector dialogs in Pd that were hidden behind windows. Or on a different desktop. (Probably a bug in the window manager. But I don't want to get there again...)

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

why? what is the problem you are experiencing?

It simply goes against the (unwritten) rules of desktop GUI development. Are you really saying this behavior is ok?

I know that I have had modal file-selector dialogs in Pd that were hidden behind windows.

Well, that's a bug in the implementation then. As I've said, a modal dialog should stay on top of the parent. In some implementations, a window-modal dialog might be hidden behind other (non-parent) windows, but even that's not a problem because it doesn't block interaction with the rest of the app.

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Even if we keep the open/save dialogs non-modal, there should be at least a mechanism to prevent the creation of multiple dialogs for the same window.

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

BTW, GIMP is a curious case: open/save dialogs are always on top of all other windows, but they are non-modal. And of course, you can't open multiple open/save dialogs for the same window ;-)

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

If you're ok with it, I would go ahead and do the following:

  • prevent multiple menu open/save dialogs for a given window
  • prevent multiple dialogs for a given [openpanel]/[savenpanel]
  • make all open/save dialogs always stay on top of the parent
  • keep make menu open/save dialogs non-modal for now
@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Are you really saying this behavior is ok?

i never said that it was ok. i was asking what the actual problem is.

If you're ok with it, I would go ahead [...]

sure.

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

i never said that it was ok.

let me quote you:

there's nothing inherently and/or obviously wrong with how the "Save As..." currently behaves.

I still don't understand why you wrote that... TBH, I didn't feel that it helped the discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.