Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects don't disappear after changing GOP settings #752

Open
HenriAugusto opened this issue Sep 23, 2019 · 3 comments

Comments

@HenriAugusto
Copy link

commented Sep 23, 2019

I've attached a small demo patch.

  1. click the bang. The subpatch's GOP area will expand exposing some objects
  2. click the bang again. The GOP area will shrink but the objects will still be visible.
  3. they will disappear in the next canvas redrawn (like if you start a selection with the mouse for ex) or if you trigger it manually using the |map 0, map 1( message.

testing-gop.txt

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

what we really need is a public (documented) method for manipulating the gop rect: #627 This takes care of the canvas redraw.

@HenriAugusto

This comment has been minimized.

Copy link
Author

commented Oct 3, 2019

Looks good. Is there anything else that needs to be done in the PR?

@Spacechild1

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

I think it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.