Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with spaces don´t open with double click #759

Open
allanfelipe opened this issue Sep 26, 2019 · 8 comments · May be fixed by #761

Comments

@allanfelipe
Copy link

commented Sep 26, 2019

Hi, I´m having an issue I didn´t have before with an older version of pd running in another computer. Now I´m with 0.50.1 in Windows 10, 64 bit. When I double click .pd files with spaces (spaces anywhere in the path), I receive the following error and pd doesn´t even start. Everything else is fine (and the files open with File/Open).
space

@umlaeute

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

what was the last version of Pd where this worked?

@allanfelipe

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

The old notebook has Pd extended 0.42.5 running in Windows Vista 32bit. Is this something that never worked in vanilla?

@porres

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

Is this something that never worked in vanilla?

If this was known, it would have been said, so I don't think it's the case.

In fact, Pd-Extended is not Pd Vanilla, so you cannot compare to it.

Can you then please test earlier vanilla versions so we can have more to investigate? It's important to know which version broke it, if any, so we can try to see how it got broken.

@Lucarda

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

@allanfelipe thanks for reporting.

I think the issue is on the installer when it writes to the registry line:
https://github.com/pure-data/pure-data/blob/master/msw/pd.nsi#L118

the ending %1 should be "%1" (quoted).

I get no error if I manually edit my registry.

(@allanfelipe If you want you can edit your registry and have it fix. Edit this entry:
HKEY_CLASSES_ROOT\PureData\shell\open\command )

@allanfelipe

This comment has been minimized.

Copy link
Author

commented Sep 29, 2019

Thanks. Indeed, this solves the problem :)

@allanfelipe allanfelipe reopened this Sep 29, 2019
@allanfelipe

This comment has been minimized.

Copy link
Author

commented Sep 29, 2019

Since the bug fix wasn't implemented, but there is a workaround, I'm not sure if the issue must be closed or not.

@porres

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

I'm not sure if the issue must be closed or not.

yeah, keep it open :)

@Lucarda Lucarda referenced a pull request that will close this issue Sep 30, 2019
@Lucarda

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2019

I made PR #761 to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.