Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: calling installer multiple times changes target path #763

Open
umlaeute opened this issue Oct 1, 2019 · 1 comment · May be fixed by #761

Comments

@umlaeute
Copy link
Contributor

commented Oct 1, 2019

When calling the 0.50-1 installer for Win64 the first time, it suggests to install Pd into %ProgramFiles%\Pd (e.g. "C:\Program Files\Pd"). Accepting this suggestion, we end up with %ProgramFiles%\Pd\bin\pd.exe (which is the proper location).

Now, when calling the installer a second time (without having uninstalled Pd), it will now suggest to install Pd into %ProgramFiles%\Pd\bin. Accepting this suggestion, we end up with %ProgramFiles%\Pd\bin\bin\pd.exe.

Calling the installer a third time (without having uninstalled Pd), it will now suggest to install Pd into %ProgramFiles%\Pd\bin\bin. Accepting this suggestion, we end up with %ProgramFiles%\Pd\bin\bin\bin\pd.exe.

Running the uninstaller (and thus wiping the registry), will reset the installation path, and the next time I run the installer I'm back to the good %ProgramFiles%\Pd suggestion.

The path seems to be taken from the ${ARCHI} field of the Software\Microsoft\Windows\CurrentVersion\App Paths\pd.exe key (the installer just strips the filename away).

Shouldn't

WriteRegStr HKLM "${PRODUCT_DIR_REGKEY}" "${ARCHI}" "$INSTDIR\bin\pd.exe"
just read:

WriteRegStr HKLM "${PRODUCT_DIR_REGKEY}" "${ARCHI}" "$INSTDIR"

i guess @Lucarda is the one to answer this

@Lucarda

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@umlaeute, right.
Here's an installer with the above changes ( it also includes the fix for #759 and other goods as pdfontloader for wish86 64bit and DejaVuSansMono-Bold.ttf both missing in the current installer)

I was expecting this installer to prompt to overwrite files if run without uninstalling but it didn't. Also with this changes I couldn't find anything broken (shortcuts, file association, etc)

I'll add this changes to PR #761.

Lucarda added a commit to Lucarda/pure-data that referenced this issue Oct 1, 2019
@Lucarda Lucarda referenced a pull request that will close this issue Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.