Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request, change order of modes in [openpanel] #816

Open
porres opened this issue Dec 7, 2019 · 2 comments · May be fixed by #830
Open

request, change order of modes in [openpanel] #816

porres opened this issue Dec 7, 2019 · 2 comments · May be fixed by #830
Labels

Comments

@porres
Copy link
Contributor

@porres porres commented Dec 7, 2019

openpanel now has two extra modes since 7136693 , see #592

but I think it makes better sense if mode 1 is 'multiple files' and 'mode 2' is 'directory.

This is because mode 0 is also getting a file, so 0 and 1 would be more closely related, then mode 2 would be for directory.

It seems less intuitive that you have mode 0 for a file, then you kinda change category to opening a directory, but then you're back to a file mode with mode 2... I hope I'm making sense here

@umlaeute

This comment has been minimized.

Copy link
Contributor

@umlaeute umlaeute commented Dec 7, 2019

hmm. using a symbol for the "mode" (eg "file", "directory", " files") might make sense, but i would rather not spend brainpower on what "seems less intuitive" about the ordering of numeric modes.

@porres

This comment has been minimized.

Copy link
Contributor Author

@porres porres commented Dec 7, 2019

i would rather not spend brainpower on what "seems less intuitive" about the ordering of numeric modes.

Yeah, I know I'm probably spending brainpower for nothing really important, but it did annoy me enough so I went for it

porres added a commit to porres/pure-data that referenced this issue Dec 10, 2019
This is a tiny revision of pure-data#592

closes pure-data#816
@umlaeute umlaeute added the feature label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.