Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[text define] crash with [sort(. #908

Open
Lucarda opened this issue Mar 18, 2020 · 7 comments · May be fixed by #722
Open

[text define] crash with [sort(. #908

Lucarda opened this issue Mar 18, 2020 · 7 comments · May be fixed by #722
Milestone

Comments

@Lucarda
Copy link
Contributor

@Lucarda Lucarda commented Mar 18, 2020

Two issues:

  • (It seems the documentation of the "sort" message is gone in current master branch. ) EDIT: Fixed with f6ef2a9

  • After doing a "sort" to [text define] I get a crash when closing the patch or Pd (on Windows or Linux).

Here's the back-trace with Msys2 GDB:

Thread 1 received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffafeb63a34 in ntdll!RtlpNtMakeTemporaryKey ()
   from /c/Windows/SYSTEM32/ntdll.dll
(gdb) bt
#0  0x00007ffafeb63a34 in ntdll!RtlpNtMakeTemporaryKey ()
   from /c/Windows/SYSTEM32/ntdll.dll
#1  0x00007ffafeb66c0e in ntdll!RtlpNtMakeTemporaryKey ()
   from /c/Windows/SYSTEM32/ntdll.dll
#2  0x00007ffafeb6780c in ntdll!RtlpNtMakeTemporaryKey ()
   from /c/Windows/SYSTEM32/ntdll.dll
#3  0x00007ffafeb1e1cd in ntdll!memset () from /c/Windows/SYSTEM32/ntdll.dll
#4  0x00007ffafc8b1cbc in msvcrt!free () from /c/Windows/system32/msvcrt.dll
#5  0x00000000673d39c9 in pd!binbuf_free ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#6  0x00000000673ac21a in rtext_mouse ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#7  0x00000000673e06a8 in pd_free ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#8  0x0000000067419ab4 in text_define_set ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#9  0x00000000673e06a8 in pd_free ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#10 0x0000000067394e79 in pd!glist_delete ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#11 0x000000006737b348 in pd!canvas_free ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#12 0x00000000673e06a8 in pd_free ()
--Type <RET> for more, q to quit, c to continue without paging--
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#13 0x00000000673dc2c7 in pd_typedmess ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#14 0x00000000673d8f6b in pd!binbuf_eval ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#15 0x00000000673e9d3d in socketreceiver_read ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#16 0x00000000673e9086 in sys_oktoloadfiles ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#17 0x00000000673ea9db in sys_pollgui ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#18 0x00000000673e25ba in pd!m_mainloop ()
   from /d/00-volatil/pure-data-update-soundfile/pd-0.50.2/bin/pd.dll
#19 0x00000000004013b4 in ?? ()
#20 0x00000000004014db in ?? ()
#21 0x00007ffafcff1611 in KERNEL32!BaseThreadInitThunk ()
   from /c/Windows/system32/KERNEL32.DLL
#22 0x00007ffafeae64ad in ntdll!RtlUserThreadStart ()
   from /c/Windows/SYSTEM32/ntdll.dll
#23 0x0000000000000000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)


On linux I get this on the terminal after the crash:

double free or corruption (out)
Pd: signal 6

@Lucarda

This comment has been minimized.

Copy link
Contributor Author

@Lucarda Lucarda commented Mar 18, 2020

@porres it seems you deleted all the "sort" part in this commit:

lines 48 - 93

01be291#diff-1c25720f88801a0c4afa56a27662461d

Can you include this info back ?

@porres

This comment has been minimized.

Copy link
Contributor

@porres porres commented Mar 19, 2020

yeah, I had worked on an older file, so when it got merged, that got lost... this is the tricky thing about updating documentation, it really had to be merged right away to avoid this. Thanks for catching that up.

@porres

This comment has been minimized.

Copy link
Contributor

@porres porres commented Mar 19, 2020

Can you include this info back ?

done with f6ef2a9

@Lucarda Lucarda changed the title [text define] documentation and crash with [sort(. [text define] crash with [sort(. Mar 19, 2020
@umlaeute

This comment has been minimized.

Copy link
Contributor

@umlaeute umlaeute commented Mar 19, 2020

@Lucarda could you provide a minimal example that triggers the crash?

umlaeute added a commit that referenced this issue Mar 19, 2020
Closes: #908
@umlaeute umlaeute added this to the 0.51 milestone Mar 19, 2020
@umlaeute umlaeute linked a pull request that will close this issue Mar 19, 2020
@Lucarda

This comment has been minimized.

Copy link
Contributor Author

@Lucarda Lucarda commented Mar 20, 2020

Here's the patch:

issue-908.zip

sort-crash

@umlaeute

This comment has been minimized.

Copy link
Contributor

@umlaeute umlaeute commented Mar 20, 2020

could you test with current update/0.50 to see whether the problem has been fixed?

@Lucarda

This comment has been minimized.

Copy link
Contributor Author

@Lucarda Lucarda commented Mar 21, 2020

Tested and is working Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.