New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Pd-extended styling #162

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@danomatika
Contributor

danomatika commented Aug 2, 2017

This is a WIP/test PR for experimenting with porting the Pd-extended styling, font metrics, and object sizing into Pd vanilla.

So far, these changes are pulled from the extended source code by looking for meaningful differences with the pd vanilla source code in the "right places." Painful.

Note: The "Pd-extended styling" doesn't mean the coloring and filled object backgrounds, just that the coloring and styles become accessible. It is not my intention to change the default vanilla styling, but this is something that could become accessible via a plugin etc.

Current Status: Not There Yet

Merge pull request #170 from pure-data/feature/font-metrics
Add dangling commits from feature/font-metrics
@porres

This comment has been minimized.

Show comment
Hide comment
@porres

porres Aug 18, 2017

Contributor

Looks fine to me right now, how can I better test this?

By the way, I notice now that some abstractions with graph on parent can also have issues with the changes in 0.48. The picture below shows an external I did and use a lot that I cannot use in 0.48 unless I change it. So I'm keeping 0.47-1 for that matter. So, I tested with this branch's version, and it looks "OK" as the picture shows.

screen shot 2017-08-18 at 14 20 38

Anyway, I feel this should have a priority as a "fix" for the 0.48 release and I'd like to help as I can

thanks

Contributor

porres commented Aug 18, 2017

Looks fine to me right now, how can I better test this?

By the way, I notice now that some abstractions with graph on parent can also have issues with the changes in 0.48. The picture below shows an external I did and use a lot that I cannot use in 0.48 unless I change it. So I'm keeping 0.47-1 for that matter. So, I tested with this branch's version, and it looks "OK" as the picture shows.

screen shot 2017-08-18 at 14 20 38

Anyway, I feel this should have a priority as a "fix" for the 0.48 release and I'd like to help as I can

thanks

@porres

This comment has been minimized.

Show comment
Hide comment
@porres

porres Aug 18, 2017

Contributor

I have to say the current release 0.48-0 actually looks nicer and feels better to read, though - I wonder if we can have the cake and eat it too

Contributor

porres commented Aug 18, 2017

I have to say the current release 0.48-0 actually looks nicer and feels better to read, though - I wonder if we can have the cake and eat it too

@danomatika

This comment has been minimized.

Show comment
Hide comment
@danomatika

danomatika Aug 18, 2017

Contributor

This is far from done and most likely not going to be finished very soon.

Contributor

danomatika commented Aug 18, 2017

This is far from done and most likely not going to be finished very soon.

@danomatika

This comment has been minimized.

Show comment
Hide comment
@danomatika

danomatika Aug 19, 2017

Contributor

Looks like the CEAMMC Pure Data fork has integrated the Pd-extended styling: https://github.com/uliss/pure-data

We can use this as a diff for this PR which could greatly speed things up.

Contributor

danomatika commented Aug 19, 2017

Looks like the CEAMMC Pure Data fork has integrated the Pd-extended styling: https://github.com/uliss/pure-data

We can use this as a diff for this PR which could greatly speed things up.

@danomatika danomatika referenced this pull request Aug 19, 2017

Open

add colors to pd #196

@porres

This comment has been minimized.

Show comment
Hide comment
@porres

porres Aug 19, 2017

Contributor

This is far from done and most likely not going to be finished very soon.

Well, I can test this in Mac, Linux, Windows, how can I help? And what are the problems we still have? Cause it looks good for the end user.

Looks like the CEAMMC Pure Data fork has integrated the Pd-extended styling: https://github.com/uliss/pure-data

Yup, it does look good

We can use this as a diff for this PR which could greatly speed things up.

Awesome

Contributor

porres commented Aug 19, 2017

This is far from done and most likely not going to be finished very soon.

Well, I can test this in Mac, Linux, Windows, how can I help? And what are the problems we still have? Cause it looks good for the end user.

Looks like the CEAMMC Pure Data fork has integrated the Pd-extended styling: https://github.com/uliss/pure-data

Yup, it does look good

We can use this as a diff for this PR which could greatly speed things up.

Awesome

@danomatika danomatika referenced this pull request Sep 23, 2017

Merged

Updated metrics and object sizing, etc #227

10 of 10 tasks complete
@danomatika

This comment has been minimized.

Show comment
Hide comment
@danomatika

danomatika Sep 23, 2017

Contributor

I have the basic sizing updates working as a bug fix and put them in a separate branch: #227

Contributor

danomatika commented Sep 23, 2017

I have the basic sizing updates working as a bug fix and put them in a separate branch: #227

@danomatika

This comment has been minimized.

Show comment
Hide comment
@danomatika

danomatika Oct 22, 2017

Contributor

Closing as this has largely been superseded by #227.

Contributor

danomatika commented Oct 22, 2017

Closing as this has largely been superseded by #227.

@danomatika danomatika closed this Oct 22, 2017

@danomatika danomatika deleted the feature/extended-styling branch Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment