New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab character in subject header shows as whitespace #13

Closed
romanofski opened this Issue Apr 4, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@romanofski
Copy link
Member

romanofski commented Apr 4, 2018

I've noticed this in an e-mail today where the subject was something like:

  cli can'    t be used for

because the e-mail underneath looked like this:

Subject: [Bug 1562010] New: rpmdeplint cli can'                                                                                                                                                                                               
_¸t be used for checking repoclosure of a single repo

Obviously I would want it to read:

[Bug 1562010] rpmdeplint cli can't be used for checking repoclosure of a single repo

without the whitespace.
Have not spent time figuring out where exactly the problem is or what it supposed to happen, but rather thought filing the bug to have a record of this.

@frasertweedale

This comment has been minimized.

Copy link
Member

frasertweedale commented Apr 5, 2018

All the whitespace including and surrounding the newline should be folded into a single space.

So it should be interpreted as cli can' t be used for, i.e. one space char after the aspotrophe.

@frasertweedale

This comment has been minimized.

Copy link
Member

frasertweedale commented Apr 5, 2018

@romanofski can you provide minimum reproducer for purebred-email itself. AFAICT it's doing the right thing.

@romanofski

This comment has been minimized.

Copy link
Member Author

romanofski commented Apr 5, 2018

I can try. Hm.. although when you say a single space then it seems to be doing the right thing... it just looks odd.

Checking in another mailer - mutt - it parses the mail the same. So... maybe there is no bug, it's just whatever produced the mail (guess Bugzilla) just stuffed up the word?

@frasertweedale

This comment has been minimized.

Copy link
Member

frasertweedale commented Apr 5, 2018

Yeah, no bug :) Closing.

@romanofski

This comment has been minimized.

Copy link
Member Author

romanofski commented Aug 3, 2018

Today I realised that the problem was actually never purebred-email. Working on the serialisation made me realise that our subject headers are still not correctly "unfolded" field bodies. Looking into this closer, I realised that we're actually showing the subject out of the index from notmuch. So it's notmuch which seems to not correctly unfolding field bodies. Once you view the mail, a folded field body (e.g the subject) is correctly shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment