Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change use of CrossVersion.full to CrossVersion.patch. #158

Merged
merged 1 commit into from Mar 9, 2017

Conversation

sh0hei
Copy link
Contributor

@sh0hei sh0hei commented Mar 8, 2017

Copy link
Collaborator

@melrief melrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh0hei thanks for the PR, it looks fine and I have only one comment: can you please revert all the changes to the style of the project? I'd like to have a clean commit for this one in case there are issues.

@sh0hei
Copy link
Contributor Author

sh0hei commented Mar 9, 2017

@melrief Revert style format :)

@melrief melrief merged commit 1578f33 into pureconfig:master Mar 9, 2017
@melrief
Copy link
Collaborator

melrief commented Mar 9, 2017

Thanks @sh0hei ! I'd like to add you to the CONTRIBUTORS file, if you agree to have your name in the project, please make another PR in which you add one line to the CONTRIBUTORS file with your name, email address and username

@sh0hei
Copy link
Contributor Author

sh0hei commented Mar 9, 2017

@melrief Of course! Thank you very much! PR will be made now.

@sh0hei sh0hei deleted the tls-compatibility branch March 9, 2017 09:50
@sh0hei sh0hei mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants