Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upupdated to PureScript 0.12 #8
Conversation
fsoikin
reviewed
Jun 27, 2018
| -- | JSON in to the resulting record value | ||
| -- | | ||
| -- | `from` and `to` indicates the the step the `Builder` will take from a `Record from` | ||
| -- | to a `Record to` so for a given `RowList` `from` will be the empty record |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fsoikin
Jun 27, 2018
I think there is a misunderstanding.
I do understand how this works. I've already spent time to understand it, and also I happen to have written similar things multiple times before.
The comment is not for me, but for future audience. Maintainability, you know.
This comment has been minimized.
This comment has been minimized.
CarstenKoenig
Jun 27, 2018
Contributor
oh shit sorry - maybe you can help me out with the wording here then
This comment has been minimized.
This comment has been minimized.
CarstenKoenig
Jun 27, 2018
Contributor
I'm really only trying to help - of course you know this ...
anyway can you have a look at it now? I hope the confusing pieces are gone and it's more obvious why to use this(?)
This comment has been minimized.
This comment has been minimized.
fsoikin
Jun 27, 2018
Don't worry too much about it, I only suggested.
I think this comment is great.
CarstenKoenig
added some commits
Jun 27, 2018
fsoikin
approved these changes
Jun 27, 2018
| -- | JSON in to the resulting record value | ||
| -- | | ||
| -- | `from` and `to` indicates the the step the `Builder` will take from a `Record from` | ||
| -- | to a `Record to` so for a given `RowList` `from` will be the empty record |
This comment has been minimized.
This comment has been minimized.
fsoikin
Jun 27, 2018
Don't worry too much about it, I only suggested.
I think this comment is great.
This comment has been minimized.
This comment has been minimized.
|
@fsoikin Since you've got an approved review in, I'll merge this tomorrow unless you have any objections. Thanks @CarstenKoenig for your work! |
This comment has been minimized.
This comment has been minimized.
|
thank you! |
This comment has been minimized.
This comment has been minimized.
fsoikin
commented
Aug 7, 2018
|
No objections, please merge. Thank you! :-) |
thomashoneyman
merged commit 96ec4b0
into
purescript-contrib:master
Aug 7, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
|
CarstenKoenig commentedJun 26, 2018
What does this pull request do?
Generic.Repcases/fields with aRowToListapproachWhere should the reviewer start?
the relevant changes should be in
Data.Argonaut.Decode.Generic.RepandData.Argonaut.Encode.Generic.RepHow should this be manually tested?
or
should do
Other Notes:
this is a cleaned up version from this PR: #6 (review)