Fix CI build? #11
Merged
Fix CI build? #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure what's going on here, psa is usually enough to fix it. I guess it'll be fixed when pulp is released anyway... |
paf31
commented
Apr 1, 2017
| "purescript-psa": "^0.3.9", | ||
| "rimraf": "^2.5.0" | ||
| "purescript": "^0.11.1", | ||
| "purescript-psa": "^0.5.0", |
Contributor
Author
There was a problem hiding this comment.
Wouldn't psa have to be installed globally so that it's on the path?
Member
There was a problem hiding this comment.
No, in fact I figured that might be the problem - npm scripts prefer the path of .bin in node_modules over the global path.
Member
There was a problem hiding this comment.
(Also I wasn't sure whether pulp checks it's neighbours for psa or whether it just tries it globally or something - the gulp or grunt plugin only used to use the npm-installed purescript when it was installed in the project)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garyb Can you please help me figure out what's wrong here? I'm assuming having
psaon the path would cause Pulp to run that instead ofpsc.