Add instances to Nullable
#13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an awful lot of new instances to the `Nullable` type. While I'm certainly not suggesting that their use should be _encouraged_, I think they are, nevertheless, valid implementations...
Author
|
So, after talking on the Slack, this is certifiably a Bad Idea™ and, rather than tainting the type, I'll push for a refactor. 😳 |
Member
|
One alternative might be to provide stand-alone versions of these functions - i.e: not as instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a load of missing instances to
Nullable. Unfortunately, a couple of these are necessary for us, but I think they're all correct. Not that I'm advocating their use, of course...