-
Notifications
You must be signed in to change notification settings - Fork 33
Feature/async incremental #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/async incremental #22
Conversation
src/Node/FS/Async.purs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it would be better handled by purescript-nullable. Then we wouldn't need to import two different versions using the FFI. Same for writeSeq. @garyb does that sound ok? Adding this as a dependency, I mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean so there's just read, and then we use toNullable on pos? Sounds good to me, that's one of the motivating use cases for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that reminds me, we should be using ^0.2.0 of node-buffer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually don't worry about this, I'll take care of it later.
|
Great, thanks very much! I just have a couple of tweaks that I want to do before I release this. |
Will this include adding the new Yesterday I wrote code that looks like this: which makes me unhappy. |
|
Yes. Also, one of those tweaks is updating to node-buffer ^0.2.0, where |
I've included a simple script I used for testing.
It would be nice to have a test suite for this library