From 650af7d38baf7ad18193fc7e136f54e2bcc44db4 Mon Sep 17 00:00:00 2001 From: Jochen Keil Date: Mon, 30 Nov 2015 19:24:22 +0100 Subject: [PATCH] Fix compiler warnings * Type variable 'a' was declared but not used. * Name 'textAlign' was shadowed. * A case expression could not be determined to cover all inputs. --- bower.json | 3 ++- src/Graphics/Canvas.purs | 9 ++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/bower.json b/bower.json index 068f926..4bf0fb3 100644 --- a/bower.json +++ b/bower.json @@ -22,6 +22,7 @@ "dependencies": { "purescript-eff": "^0.1.0", "purescript-functions": "^0.1.0", - "purescript-maybe": "^0.3.0" + "purescript-maybe": "^0.3.0", + "purescript-exceptions": "^0.3.1" } } diff --git a/src/Graphics/Canvas.purs b/src/Graphics/Canvas.purs index 2873a6c..bce3b13 100644 --- a/src/Graphics/Canvas.purs +++ b/src/Graphics/Canvas.purs @@ -109,6 +109,7 @@ import Prelude import Data.Function import Data.Maybe import Control.Monad.Eff +import Control.Monad.Eff.Exception.Unsafe (unsafeThrow) -- | The `Canvas` effect denotes computations which read/write from/to the canvas. foreign import data Canvas :: ! @@ -134,7 +135,7 @@ foreign import data CanvasGradient :: * foreign import canvasElementToImageSource :: CanvasElement -> CanvasImageSource -- | Wrapper for asynchronously loading a image file by path and use it in callback, e.g. drawImage -foreign import withImage :: forall eff a. String -> (CanvasImageSource -> Eff eff Unit) -> Eff eff Unit +foreign import withImage :: forall eff. String -> (CanvasImageSource -> Eff eff Unit) -> Eff eff Unit foreign import getCanvasElementByIdImpl :: forall r eff. Fn3 String @@ -403,13 +404,15 @@ textAlign ctx = unsafeParseTextAlign <$> textAlignImpl ctx unsafeParseTextAlign "center" = AlignCenter unsafeParseTextAlign "start" = AlignStart unsafeParseTextAlign "end" = AlignEnd + unsafeParseTextAlign align = unsafeThrow $ "invalid TextAlign: " ++ align + -- ^ dummy to silence compiler warnings foreign import setTextAlignImpl :: forall eff. Context2D -> String -> (Eff (canvas :: Canvas | eff) Context2D) -- | Set the current text alignment. setTextAlign :: forall eff. Context2D -> TextAlign -> Eff (canvas :: Canvas | eff) Context2D -setTextAlign ctx textAlign = - setTextAlignImpl ctx (show textAlign) +setTextAlign ctx textalign = + setTextAlignImpl ctx (show textalign) -- | Text metrics: -- |