Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HTTPure to latest version with dependencies #1059

Merged
merged 3 commits into from Feb 2, 2022

Conversation

danielstaleiny
Copy link
Contributor

First time doing this. Do I need to validate anything to make sure it is correct ?

compared dependencies and fixed them in package-sets and up the version. Is there anything eles I need to do to make latest version available ?

https://github.com/cprussin/purescript-httpure

@danielstaleiny
Copy link
Contributor Author

danielstaleiny commented Jan 25, 2022

Note: httpure-middleware which depends on httpure fails to build after I patched httpure localy to latest version. I verified it with spago verify httpure.

@thomashoneyman
Copy link
Member

thomashoneyman commented Jan 25, 2022

@danielstaleiny If updating a package will remove downstream packages from the set, we usually try to notify the packages that will be dropped from the set downstream by opening an issue on their repository and give them up to a week to make the changes they need to remain included in the package set. That keeps package set upgrades smooth for users.

I've opened an issue on httpure-middleware about this; regardless of the response, we can merge this in a few days. If the author doesn't want to fix the package then we will remove httpure-middleware from the package set so that your PR can go through.

@thomashoneyman
Copy link
Member

@danielstaleiny Would you mind removing httpure-middleware from the package sets and regenerating the packages.json file? Then I can merge this for you!

@danielstaleiny
Copy link
Contributor Author

I removed httpure-middleware both from package.json and from dhall file. However I have no idea how to generate automatically package.json so I did it manually(which I understand is error prone) so for future, what command am I suppose to run to make it re-generate ?

@danielstaleiny
Copy link
Contributor Author

I am blind. I was looking in Readme.

[nix-shell:~/work/github/package-sets]$ ./verify-registry.sh
[SUCCESS] All packages are in the registry
[SUCCESS] All package URLs are matching the Registry

@thomashoneyman
Copy link
Member

You can see the instructions here:
https://github.com/purescript/package-sets/blob/master/CONTRIBUTING.md#how-to-add-a-package-to-the-set

@thomashoneyman thomashoneyman merged commit 6cda8d9 into purescript:master Feb 2, 2022
@danielstaleiny
Copy link
Contributor Author

No change.

λ package-sets master ✓ nix-shell --command make
formatted dhall files
generated to packages.json

@thomashoneyman
Copy link
Member

I'd only expect a change if you hadn't already manually done the packages.json change -- but for the future, once you edit the .dhall file you can then just run nix-shell --command make and commit the result!

@danielstaleiny
Copy link
Contributor Author

I get the flow now. and Yes, I just double check to see that there are indeed no changes. (Therefore I did manual change correctly.)

thanks for info and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants