/psc-package

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add-from-bower #121

Closed
justinwoo opened this Issue Jun 26, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
help wanted question
Projects
None yet
Milestone
No milestone
1 participant
@justinwoo
@justinwoo
Copy link
Collaborator

justinwoo commented Jun 26, 2018

Even though I implemented this feature, I think it's proven to only confuse users into thinking they will get some kind of "extra-deps" behavior, and this really should exist as a separate tool that just uses bower-the-library (e.g. I have the beginnings of one here: https://github.com/justinwoo/get-package-def).

I've basically already implemented the core of what this is for my own package sets project anyhow with a simple Perl script: https://github.com/justinwoo/spacchetti/blob/c2a7cc4fdaadba2d09cb077fea2758e74e3f2818/prepare-bower.pl

So can we get to removing this? Is there anyone who actually likes add-from-bower and can speak for it?

@justinwoo justinwoo added help wanted question labels Jun 26, 2018

@justinwoo

This comment has been minimized.

Sign in to view
Copy link
Collaborator

justinwoo commented Jun 27, 2018

In my Twitter poll I received only "yes, remove" votes

@justinwoo justinwoo referenced this issue Jun 27, 2018

Merged

Remove add-from-bower #122

@justinwoo

This comment has been minimized.

Sign in to view
Copy link
Collaborator

justinwoo commented Jun 28, 2018

Fixed in #122

@justinwoo justinwoo closed this Jun 28, 2018

@justinwoo justinwoo referenced this issue Jul 25, 2018

Merged

psc-package: 0.3.2 -> 0.4.1 #44084

0 of 9 tasks complete

Profpatsch added a commit to justinwoo/nixpkgs that referenced this issue Jul 28, 2018

@justinwoo @Profpatsch
psc-package: 0.3.2 -> 0.4.1 
Updates that remove features and improve user experience.

Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch)
Filters "installing" messages for build (purescript/psc-package#130 by @Dretch)
Adds options for limiting jobs for install (purescript/psc-package#127 by @vladciobanu)
Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
eff76a6

Profpatsch added a commit to NixOS/nixpkgs that referenced this issue Jul 28, 2018

@justinwoo @Profpatsch
psc-package: 0.3.2 -> 0.4.1 
Updates that remove features and improve user experience.

Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch)
Filters "installing" messages for build (purescript/psc-package#130 by @Dretch)
Adds options for limiting jobs for install (purescript/psc-package#127 by @vladciobanu)
Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
7dadfbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment