Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake V Monoid #12
Conversation
paf31
reviewed
May 4, 2017
src/Data/Validation/Semigroup.purs
Outdated
| @@ -70,3 +71,9 @@ instance applyV :: (Semigroup err) => Apply (V err) where | |||
|
|
|||
| instance applicativeV :: (Semigroup err) => Applicative (V err) where | |||
| pure = Valid | |||
|
|
|||
| instance semigroupV :: (Semigroup err, Semigroup a) => Semigroup (V err a) where | |||
| append x y = append <$> x <*> y | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
safareli
May 4, 2017
Contributor
I guess not, but difference should be really small right?
Also javascript runtime could optimise lift2 if it's called too often.
paf31
reviewed
May 4, 2017
src/Data/Validation/Semiring.purs
Outdated
| @@ -77,6 +78,12 @@ instance applyV :: (Semiring err) => Apply (V err) where | |||
| instance applicativeV :: (Semiring err) => Applicative (V err) where | |||
| pure = Valid | |||
|
|
|||
| instance semigroupV :: (Semiring err, Semigroup a) => Semigroup (V err a) where | |||
| append x y = append <$> x <*> y | |||
This comment has been minimized.
This comment has been minimized.
safareli
force-pushed the
safareli:monoid
branch
from
0f43bb6
to
788634d
May 4, 2017
This comment has been minimized.
This comment has been minimized.
|
@paf31 @kRITZCREEK ping |
paf31
merged commit f934666
into
purescript:master
Jun 3, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
safareli
deleted the
safareli:monoid
branch
Jun 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
safareli commentedMay 3, 2017
No description provided.