/purescript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove poor performing entails.filterModule #1161

Merged
merged 1 commit into from Jun 11, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@puffnfresh @garyb @paf31 @jdegoes
@puffnfresh
Contributor

puffnfresh commented Jun 11, 2015

Turns out this was the last thing using the getTypeClassDictionaries
list, but was also filtering down to the module. Changed to using the
underlying Map, which provides quick indexing of the module.

Some more numbers:

benchmarking unpatched
time                 59.75 s    (51.44 s .. 67.70 s)
                     0.998 R²   (NaN R² .. 1.000 R²)
mean                 59.01 s    (57.54 s .. 60.14 s)
std dev              1.737 s    (0.0 s .. 1.954 s)
variance introduced by outliers: 19% (moderately inflated)

benchmarking patched
time                 32.53 s    (25.64 s .. 39.85 s)
                     0.994 R²   (0.977 R² .. 1.000 R²)
mean                 33.09 s    (31.42 s .. 34.06 s)
std dev              1.496 s    (0.0 s .. 1.670 s)
variance introduced by outliers: 19% (moderately inflated)

I have no idea why Criterion gives a NaN...
@puffnfresh
Remove poor performing entails.filterModule 
Turns out this was the last thing using the getTypeClassDictionaries
list, but was also filtering down to the module. Changed to using the
underlying Map, which provides quick indexing of the module.

Some more numbers:

    benchmarking unpatched
    time                 59.75 s    (51.44 s .. 67.70 s)
                         0.998 R²   (NaN R² .. 1.000 R²)
    mean                 59.01 s    (57.54 s .. 60.14 s)
    std dev              1.737 s    (0.0 s .. 1.954 s)
    variance introduced by outliers: 19% (moderately inflated)

    benchmarking patched
    time                 32.53 s    (25.64 s .. 39.85 s)
                         0.994 R²   (0.977 R² .. 1.000 R²)
    mean                 33.09 s    (31.42 s .. 34.06 s)
    std dev              1.496 s    (0.0 s .. 1.670 s)
    variance introduced by outliers: 19% (moderately inflated)

I have no idea why Criterion gives a NaN...
40ad1cf
@garyb

This comment has been minimized.

Show comment
Hide comment
@garyb

garyb Jun 11, 2015

Member

😍
Member

garyb commented Jun 11, 2015

😍
@paf31

This comment has been minimized.

Show comment
Hide comment
@paf31

paf31 Jun 11, 2015

Member

👍
Member

paf31 commented Jun 11, 2015

👍
@jdegoes

This comment has been minimized.

Show comment
Hide comment
@jdegoes

jdegoes Jun 11, 2015

Only doubling performance? You're slipping, dude! 😉

💯 🎆 😂

jdegoes commented Jun 11, 2015

Only doubling performance? You're slipping, dude! 😉

💯 🎆 😂

paf31 added a commit that referenced this pull request Jun 11, 2015

@paf31
Merge pull request #1161 from puffnfresh/perf/entails-filtermodule 
Remove poor performing entails.filterModule
2021aa0

@paf31 paf31 merged commit 2021aa0 into purescript:master Jun 11, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment