Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude full file path in CJS requires. #3314
Conversation
This comment has been minimized.
This comment has been minimized.
|
Ah, I bet some of these problems are fixed in #3312, as the deps I've been tinkering with appear to have been bumped and fixed in that PR. Also, it looks like stuff missing from Prim could be fixed by that PR, as it's moving them from lib to compiler (if I read it right). The other question I have is about tests -- do we need to have some tests written to assert this? If you ask me, I don't think it's necessary. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's why I want this patch, BTW. https://www.screencast.com/t/KgVyC3ksG or https://1drv.ms/v/s!AnIo6jtaL-CjkG-zDxXZxVHIc-8s No need to add a bundle or transpile step PureScript code during development -- just refer directly to the single PS module and the dependencies will be dynamically loaded. (Yeah, SystemJS does transpile, but it seems to be much easier to get started with, I think.) The bundling step is often a hurdle for Haskell people coming to PureScript. Yes, tooling like |
LiamGoodacre
merged commit 8ae2a06
into
purescript:master
Apr 23, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
chexxor commentedApr 21, 2018
Fixes #2621
Changes the JS output from
require("../SomeModule")torequire("../SomeModule/index.js"), and same for the implicit FFI imports.stack testis proving difficult. First time I ran it, it had trouble installing bower dependencies, givingECONFLICT Unable to find suitable version for purescript-either. After manually installing them, I got errors aboutMonoidbeing a duplicate module, which occurred because it's been moved to Prelude in the latest version (so we may need to adjust the version range in the bower file). After manually deleting Monoid stuff from the PS Prelude it was using, I get test failures caused by stuff missing from Prim --Module Prim.RowList was not found., and same for Prim.Ordering and Prim.Symbol.