Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce `--codegen` argument so targets can be specified explicitly #3324
Conversation
gabejohnson
and others
added some commits
Feb 26, 2018
garyb
added
the
ready for review
label
Apr 27, 2018
This comment has been minimized.
This comment has been minimized.
|
Any thoughts/comments about this @kRITZCREEK @LiamGoodacre @hdgarrood? |
This comment has been minimized.
This comment has been minimized.
|
|
| targetParser :: Opts.ReadM [P.CodegenTarget] | ||
| targetParser = | ||
| Opts.str >>= \s -> | ||
| for (T.split (== ',') s) |
This comment has been minimized.
This comment has been minimized.
kRITZCREEK
Apr 27, 2018
Member
Do we want to be a bit more lenient here and strip the text after splitting?
This comment has been minimized.
This comment has been minimized.
garyb
Apr 27, 2018
Member
I'm not sure how you'd get spaces into that value anyway? Since --codegen js, corefn wouldn't parse as one thing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Awesome. No comments other than what @kRITZCREEK raised. |
kRITZCREEK
reviewed
Apr 27, 2018
app/Command/Compile.hs
Outdated
| @@ -154,6 +154,8 @@ targetParser = | |||
| $ maybe (Opts.readerError targetsMessage) pure | |||
| . flip M.lookup targets | |||
| . T.unpack | |||
| . T.takeWhile (/= ' ') | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
garyb
force-pushed the
garyb:customisable-codegen
branch
from
99547dd
to
c40b016
Apr 27, 2018
LiamGoodacre
approved these changes
Apr 27, 2018
garyb
merged commit 91e77b7
into
purescript:master
Apr 27, 2018
garyb
deleted the
garyb:customisable-codegen
branch
Apr 27, 2018
hdgarrood
referenced this pull request
May 3, 2018
Closed
Update to use new --codegen flag when producing source maps #343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
garyb commentedApr 26, 2018
Resolves #3196, closes #3258
Default is
js, usingsourcemapsimpliesjsand the separate option for source maps is gone now.Thanks to @gabejohnson for doing the first part of this!