-
Notifications
You must be signed in to change notification settings - Fork 134
Look up remote imports dynamically when doing frozen check #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@f-f Submitting this as a draft to check I'm working along the same lines as you were thinking. If so I'll do the tests, changelog, etc. The |
f-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elliotdavies yes this is exactly what I was looking for! I left some minor suggestions but it's almost ready to go 🙂
|
@f-f Ace - I'll try to get this done today in the hopes of making the v10 release 😄 |
|
@f-f Ready to re-review I think! |
f-f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot @elliotdavies! 👏
|
@f-f Awesome! One other thing - at the moment we call |
|
@elliotdavies great point, and I'm not sure how to solve it. We could try moving the print around (e.g. in |
Description of the change
To fix #349 we no longer look for
packages.dhalldirectly when checking that the remote imports are frozen. Instead we look atspago.dhalland check all remote imports in its dependency graph.Checklist:
Added some example of the new feature to theREADMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊