Speedup version bump tests #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Oct 6, 2019
jhrcek
commented
Oct 6, 2019
Dretch
reviewed
Oct 6, 2019
|
|
||
| spago ["bump-version", "minor"] >>= shouldBeSuccess | ||
| getHighestTag >>= (`shouldBe` Just "v1.2.3") | ||
| -- TODO should this work or should we strip these in parser implementation? |
Contributor
There was a problem hiding this comment.
PREREL / META should probably be allowed - for one thing because there are existing packages that have such versions - e.g. halogen v5.0.0-rc.7.
| parseVersionBump "1.2.3" `shouldBe` Just (Exact (SemVer 1 2 3 [] [])) | ||
|
|
||
| before_ (initGitTag "v1.2.3") $ it "Spago should not make a tag when not passing --no-dry-run" $ do | ||
| -- TODO is this desired behavior, or should we just drop ONE 'v'? I'd agree it's edge case, but still :-) |
Dretch
approved these changes
Oct 6, 2019
Contributor
Author
|
@f-f just wanted to check with you what's the general strategy around PR reviews. Should I wait for your review/approval before I merge, or is just one review enough, like in the case of this PR? |
Member
|
@jhrcek great point, thanks for asking. This has not come up before so that's why we don't have a written policy about it yet I think a review from a contributor is enough to merge, no need to wait for my review :) |
Member
|
@jhrcek thanks for doing this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Attempt to speed up test suite by focusing on the slowest tests as described in #440
Locally this change seems to have shaved off ~20s of test running time.
Checklist:
README