From c480bd94db5147fec09a336fb67eac5333091524 Mon Sep 17 00:00:00 2001 From: James Shubin Date: Sat, 25 Feb 2017 21:29:08 -0500 Subject: [PATCH] resources: virt: Remove unnecessary early exit from CheckApply I don't think this early exit is necessary any more, since the main CheckApply function really just spawns out to the different sub workers which all individually check the apply variable. If I'm wrong, we can revert this. It was @roidelapluie that noticed the check here to begin with. --- resources/virt.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/resources/virt.go b/resources/virt.go index 590823539..b8ce0c192 100644 --- a/resources/virt.go +++ b/resources/virt.go @@ -836,11 +836,6 @@ func (obj *VirtRes) CheckApply(apply bool) (bool, error) { // FIXME: should we wait to ensure machine is booted before continuing? // it may be useful to wait for guest agent to hotplug some ram or cpu! - if !apply { - return false, nil - } - // remaining apply portion - // mem & cpu checks... if !obj.absent { if c, err := obj.attrCheckApply(apply, dom); err != nil {