don't bother watching if we would never pass the predicates

pusher · Sep 24, 2019 · 7d66c77 · 7d66c77
1 parent b8d4204
commit 7d66c77
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/pkg/controller/gittrackobject/gittrackobject_controller.go b/pkg/controller/gittrackobject/gittrackobject_controller.go
@@ -113,17 +113,20 @@ func add(mgr manager.Manager, r reconcile.Reconciler, opts *reconcileGitTrackObj
 	}
 
 	// Watch for changes to GitTrackObject
-	predicate := []predicate.Predicate(nil)
+	var predicate []predicate.Predicate
 	if opts.clusterGitTrackMode == farosflags.CGTMExcludeNamespaced {
 		predicate = append(predicate, utils.NewOwnerIsNotClusterGitTrackPredicate(mgr.GetClient()))
 	}
 	if opts.gitTrackMode == farosflags.GTMDisabled {
 		predicate = append(predicate, utils.NewOwnerIsNotGitTrackPredicate(mgr.GetClient()))
 	}
 
-	err = c.Watch(&source.Kind{Type: &farosv1alpha1.GitTrackObject{}}, &handler.EnqueueRequestForObject{}, predicate...)
-	if err != nil {
-		return err
+	// don't bother putting a watch on gittrackobjects if we are entirely disabled
+	if len(predicate) != 2 {
+		err = c.Watch(&source.Kind{Type: &farosv1alpha1.GitTrackObject{}}, &handler.EnqueueRequestForObject{}, predicate...)
+		if err != nil {
+			return err
+		}
 	}
 
 	if opts.clusterGitTrackMode != farosflags.CGTMDisabled {