Implement ValidateSessionState for GitHubProvider #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iain-buclaw-sociomantic
requested review from
JoelSpeed,
steakunderscore and
loshz
as code owners
JoelSpeed
reviewed
Feb 7, 2020
There was a problem hiding this comment.
I think this is ok, will need a changelog entry and verifying before we merge though
Thanks @iain-buclaw-sociomantic for a quick turnaround on this
loshz
previously approved these changes
Feb 7, 2020
Refactors the setting of the Authorization header into getGitHubHeader. Refs #382
|
Added changelog entry, due to the nature of Github's alerting system, we'll have to wait at least three days for confirmation of fix. Running this patch on one node, I see no problems with the functionality of |
|
I have received no further emails from GitHub so far, so knock wood it will stay that way. |
|
Would this be enough to release a v5.0.1? Looks good to me, by the way. Really thankful, @iain-buclaw-sociomantic 👍 |
|
This will be released as 5.0.1? any plans to merge and release this fix? thanks! |
JoelSpeed
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the setting of the Authorization header into getGitHubHeader.
Refs #382
@JoelSpeed - at the risk of doing something you are already looking at, this change is untested, but looks like it should fix the referenced problem.