Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to explain that a client must be connected during tests #42

Merged
merged 1 commit into from Jun 20, 2015

Conversation

WillSewell
Copy link
Contributor

@leggetter what do you think? I didn't know I had to do this at first, and it wasn't clear from the error messages.

@leggetter
Copy link
Contributor

👍 Although the test error messages do say that it's nice to have it in the docs too. I'd remove your app_id from the URL and replace it with YOUR_TEST_APP_ID.

@WillSewell WillSewell force-pushed the improve_testing_instructions branch from df5fdd2 to e8cff9f Compare May 13, 2015 16:02
@WillSewell
Copy link
Contributor Author

OK cool. Thanks, forgot to remove the app id!

WillSewell added a commit that referenced this pull request Jun 20, 2015
Update readme to explain that a client must be connected during tests
@WillSewell WillSewell merged commit 4c0f016 into master Jun 20, 2015
@WillSewell WillSewell deleted the improve_testing_instructions branch June 20, 2015 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants