Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed incorrect exception thrown for missing EM #38

Merged
merged 1 commit into from Feb 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

jdudek commented Feb 22, 2013

The Client#em_http_client method checks whether EventMachine is available. However, the #send_async method tries to create an instance of EM::DefaultDeferrable before this check, which causes NameError: uninitialized constant Pusher::Request::EM instead of expected exception Pusher::Error: In order to use async calling you must be running inside an eventmachine loop.

@mloughran mloughran added a commit that referenced this pull request Feb 25, 2013

@mloughran mloughran Merge pull request #38 from jdudek/patch-1
Fixed incorrect exception thrown for missing EM
75fbfca

@mloughran mloughran merged commit 75fbfca into pusher:master Feb 25, 2013

1 check passed

default The Travis build passed
Details
Contributor

mloughran commented Feb 25, 2013

Good point, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment