2.2.0 Pusher Options encrypted to forceTLS #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdpye
reviewed
Apr 21, 2020
mdpye
reviewed
Apr 21, 2020
| */ | ||
| public PusherOptions setEncrypted(final boolean encrypted) { | ||
| this.encrypted = encrypted; | ||
| public PusherOptions setForceTLS(boolean forceTLS) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public PusherOptions setForceTLS(boolean forceTLS) { | |
| public PusherOptions setForceTLS(final boolean forceTLS) { |
Just for consistency 🤷
mdpye
approved these changes
Apr 21, 2020
Co-Authored-By: Mike Pye <mail@mdpye.co.uk>
daniellevass
changed the title
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
+ Coverage 75.90% 75.93% +0.02%
- Complexity 277 279 +2
============================================
Files 33 33
Lines 2415 2418 +3
Branches 112 112
============================================
+ Hits 1833 1836 +3
Misses 527 527
Partials 55 55
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Refactored the PusherOption
encryptedtoforceTLS. Have annotated with@deprecatedthe previous methods to let existing people know....
Why is the change necessary?
The other libraries updated to
forceTLSto reduce confusion between private encrypted channels....
CC @pusher/mobile