New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST Auth Parameter with HTTP Body #22

Merged
merged 1 commit into from Jan 24, 2016

Conversation

Projects
None yet
2 participants
@hamchapman
Copy link
Member

hamchapman commented Jan 24, 2016

We have to send post auth data in HTTP Body

馃檯

# Current implementation
curl -XPOST 'https://circleci.com/auth/pusher?circle-token=foobar?socket_id=123456.87654321&channel_name=private-test'

# This also fails
curl -XPOST 'https://circleci.com/auth/pusher?circle-token=foobar&socket_id=123456.87654321&channel_name=private-test'

馃檰

curl 'https://circleci.com/auth/pusher?circle-token=foobar' \
  --data 'socket_id=123456.87654321&channel_name=private-test'

Replaces #20

POST Auth Parameter with HTTP Body
We have to send post auth data in HTTP Body

## 馃檯

```sh
# Current implementation
curl -XPOST 'https://circleci.com/auth/pusher?circle-token=foobar?socket_id=123456.87654321&channel_name=private-test'

# This also fails
curl -XPOST 'https://circleci.com/auth/pusher?circle-token=foobar&socket_id=123456.87654321&channel_name=private-test'
```

## 馃檰

```sh
curl 'https://circleci.com/auth/pusher?circle-token=foobar' \
  --data 'socket_id=123456.87654321&channel_name=private-test'
```

hamchapman added a commit that referenced this pull request Jan 24, 2016

Merge pull request #22 from pusher-community/ngs/patch-1
POST Auth Parameter with HTTP Body

@hamchapman hamchapman merged commit 3005c21 into master Jan 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hamchapman hamchapman deleted the ngs/patch-1 branch Jan 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment